[Webkit-unassigned] [Bug 191715] Caret stops blinking after context menu shown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191715

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355081|review+                     |review?
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 355081
  --> https://bugs.webkit.org/attachment.cgi?id=355081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355081&action=review

Thanks for the fix! The code change looks good but there are a few nits to fix.

> Source/WebCore/page/EventHandler.cpp:2883
> +    

Nit: Whitespace.

> LayoutTests/fast/events/contextmenu-dismiss-blink-caret.html:3
> +    <div id="contenteditable" contenteditable>This tests whether the caret continues to blink after the context menu is dismissed.</div>

Please add an instruction to run this test manually in the browser.
This is important so that QA folks, etc... can run this test manually to verify the fix,
and also in the future this test ever gets broken, to be able to bisect using a browser.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181116/f0bc7271/attachment.html>