[Webkit-unassigned] [Bug 191713] [CMake][AppleWin] Use DEBUG_SUFFIX only where needed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 14:22:02 PST 2018


Don Olmstead <don.olmstead at sony.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED
           Assignee|webkit-unassigned at lists.web |don.olmstead at sony.com
                   |kit.org                     |

--- Comment #1 from Don Olmstead <don.olmstead at sony.com> ---
Created attachment 354987

  --> https://bugs.webkit.org/attachment.cgi?id=354987&action=review

WIP Patch

This fixes all incorrect usages of ${DEBUG_SUFFIX} within CMake files.

To test the build I ran the following command to pretend I had an internal AppleWin build.

perl Tools\Scripts\build-webkit --wincairo --64-bit --debug --cmakeargs="-DDEBUG_SUFFIX=_debug"

I had to do some build fixes so I suspect that the internal Apple Windows build might be having issues but I can't verify since I don't have access.

Also the adding of ${DEBUG_SUFFIX} is not consistent. There are a number of places where produced executables and libraries do not have a debug suffix. All the WEBKIT_FRAMEWORKS have _debug.lib, e.g. WTF_debug.lib/dll. Some executables have them, e.g. jsc_debug.exe, but not others, MiniBrowser.exe.

Anyways this builds now so we can go from here in terms of fixing it all.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181115/c912748c/attachment.html>

More information about the webkit-unassigned mailing list