[Webkit-unassigned] [Bug 191713] New: [CMake][AppleWin] Use DEBUG_SUFFIX only where needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191713

            Bug ID: 191713
           Summary: [CMake][AppleWin] Use DEBUG_SUFFIX only where needed
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CMake
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: don.olmstead at sony.com

MSVC builds executable code into the same directory structure regardless of configuration. For full debug builds of internal AppleWin builds DEBUG_SUFFIX is set to separate release and debug build artifacts. CMake files were modified to support this but it appears that ${DEBUG_SUFFIX} is used in places where it isn't needed.

# Correct usage we're just setting the output name
set(WTF_OUTPUT_NAME WTF${DEBUG_SUFFIX})
# Correct usage this library is built outside of the WebKit tree
target_link_libraries(WebKitQuartzCoreAdditions CoreFoundation${DEBUG_SUFFIX})

# Incorrect usage since CMake builds the library and will know the output name
set(test_wtf_LIBRARIES WTF${DEBUG_SUFFIX})

All incorrect usages should be removed assuming CMake is functioning as I suspect it will.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181115/cb1199c5/attachment.html>