[Webkit-unassigned] [Bug 191660] REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191660

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
(In reply to Chris Dumez from comment #2)
> TEST(ProcessSwap, NavigateToInvalidURL)
> {
>     auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration
> alloc] init]);
>     processPoolConfiguration.get().processSwapsOnNavigation = YES;
>     auto processPool = adoptNS([[WKProcessPool alloc]
> _initWithConfiguration:processPoolConfiguration.get()]);
> 
>     auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc]
> init]);
>     [webViewConfiguration setProcessPool:processPool.get()];
>     auto handler = adoptNS([[PSONScheme alloc]
> initWithBytes:navigateToInvalidURLTestBytes]);
>     [webViewConfiguration setURLSchemeHandler:handler.get()
> forURLScheme:@"PSON"];
> 
>     auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0,
> 800, 600) configuration:webViewConfiguration.get()]);
>     auto navigationDelegate = adoptNS([[PSONNavigationDelegate alloc] init]);
>     [webView setNavigationDelegate:navigationDelegate.get()];
>     auto uiDelegate = adoptNS([[PSONUIDelegate alloc]
> initWithNavigationDelegate:navigationDelegate.get()]);
>     [webView setUIDelegate:uiDelegate.get()];
> 
>     numberOfDecidePolicyCalls = 0;
>     [webView loadRequest:[NSURLRequest requestWithURL:[NSURL
> URLWithString:@"pson://www.webkit.org/main.html"]]];
>     TestWebKitAPI::Util::run(&done);
>     done = false;
>     auto pid1 = [webView _webProcessIdentifier];
>     EXPECT_TRUE(!!pid1);
> 
>     TestWebKitAPI::Util::run(&didReceiveAlert);
>     didReceiveAlert = false;
>     auto pid2 = [webView _webProcessIdentifier];
>     EXPECT_TRUE(!!pid2);
> 
>     EXPECT_EQ(2, numberOfDecidePolicyCalls);
>     EXPECT_EQ(pid1, pid2);
> }
> 
> Since the safe browsing check, we're getting one
> decidePolicyForNavigationAction call instead of 2. Previously there would be
> one for "pson://www.webkit.org/main.html" and presumably another one for the
> invalid URL load 'http://A=a%B=b'.
> 
> Alex?

Oh, I think this is just a timing issue and the safe browsing check merely delayed things by a bit. I am investigate. Likely, I just need to write the test in a better way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181114/e7774f4b/attachment.html>