[Webkit-unassigned] [Bug 191582] New: [curl] CurlDownload and CookieJarCurl: warning: delete called on non-final that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]

Tue Nov 13 01:36:32 PST 2018

https://bugs.webkit.org/show_bug.cgi?id=191582

            Bug ID: 191582
           Summary: [curl] CurlDownload and CookieJarCurl: warning: delete
                    called on non-final that has virtual functions but
                    non-virtual destructor [-Wdelete-non-virtual-dtor]
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com

clang-cl reports following compilation warnings while building WinCairo port.

> [5002/6237] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\network\curl\CurlDownload.cpp.obj
> In file included from ..\..\Source\WebCore\platform\network\curl\CurlDownload.cpp:29:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlDownload.h:32:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequest.h:32:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequestSchedulerClient.h:17:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlContext.h:30:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlSSLHandle.h:30:
> In file included from ..\..\WebKitLibraries\win\include\openssl/crypto.h:129:
> ..\..\WebKitLibraries\win\include\openssl/ossl_typ.h(86,9):  warning: Warning, overriding WinCrypt defines [-W#pragma-messages]
> #pragma message("Warning, overriding WinCrypt defines")
>         ^
> In file included from ..\..\Source\WebCore\platform\network\curl\CurlDownload.cpp:29:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlDownload.h:32:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequest.h:29:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlFormDataStream.h:30:
> In file included from ..\..\Source\WebCore\platform\network/FormData.h:22:
> In file included from ..\..\Source\WebCore\platform\network/BlobData.h:35:
> In file included from ..\..\Source\WebCore\platform\ThreadSafeDataBuffer.h:28:
> DerivedSources\ForwardingHeaders\wtf/ThreadSafeRefCounted.h(76,13):  warning: delete called on non-final 'WebCore::CurlDownload' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
>             delete static_cast<const T*>(this);
>             ^
> ..\..\Source\WebCore\platform\network\curl/CurlDownload.h(56,65):  note: in instantiation of member function 'WTF::ThreadSafeRefCounted<WebCore::CurlDownload, WTF::DestructionThread::Any>::deref' requested here
>     void deref() override { ThreadSafeRefCounted<CurlDownload>::deref(); }
>                                                                 ^
> In file included from ..\..\Source\WebCore\platform\network\curl\CurlDownload.cpp:29:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlDownload.h:32:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlRequest.h:29:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlFormDataStream.h:30:
> In file included from ..\..\Source\WebCore\platform\network/FormData.h:22:
> In file included from ..\..\Source\WebCore\platform\network/BlobData.h:35:
> In file included from ..\..\Source\WebCore\platform\ThreadSafeDataBuffer.h:28:
> DerivedSources\ForwardingHeaders\wtf/ThreadSafeRefCounted.h(80,13):  warning: delete called on non-final 'WebCore::CurlDownload' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
>             delete static_cast<const T*>(this);
>             ^
> 3 warnings generated.

> [5019/6237] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\network\curl\NetworkStorageSessionCurl.cpp.obj
> In file included from ..\..\Source\WebCore\platform\network\curl\NetworkStorageSessionCurl.cpp:35:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlContext.h:30:
> In file included from ..\..\Source\WebCore\platform\network\curl/CurlSSLHandle.h:30:
> In file included from ..\..\WebKitLibraries\win\include\openssl/crypto.h:129:
> ..\..\WebKitLibraries\win\include\openssl/ossl_typ.h(86,9):  warning: Warning, overriding WinCrypt defines [-W#pragma-messages]
> #pragma message("Warning, overriding WinCrypt defines")
>         ^
> In file included from ..\..\Source\WebCore\platform\network\curl\NetworkStorageSessionCurl.cpp:26:
> In file included from ..\..\Source\WebCore\config.h:51:
> In file included from DerivedSources\ForwardingHeaders\wtf/FastMalloc.h:25:
> In file included from DerivedSources\ForwardingHeaders\wtf/StdLibExtras.h:30:
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2055,3):  warning: delete called on non-final 'WebCore::CookieJarCurlDatabase' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
>                 delete _Ptr;
>                 ^
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2267,4):  note: in instantiation of member function 'std::default_delete<WebCore::CookieJarCurlDatabase>::operator()' requested here
>                         this->get_deleter()(get());
>                         ^
> DerivedSources\ForwardingHeaders\wtf/UniqueRef.h(33,28):  note: in instantiation of member function 'std::unique_ptr<WebCore::CookieJarCurlDatabase, std::default_delete<WebCore::CookieJarCurlDatabase> >::~unique_ptr' requested here
> template<typename T> class UniqueRef;
>                            ^
> In file included from ..\..\Source\WebCore\platform\network\curl\NetworkStorageSessionCurl.cpp:26:
> In file included from ..\..\Source\WebCore\config.h:51:
> In file included from DerivedSources\ForwardingHeaders\wtf/FastMalloc.h:25:
> In file included from DerivedSources\ForwardingHeaders\wtf/StdLibExtras.h:30:
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2055,3):  warning: delete called on 'WebCore::CookieJarCurl' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]
>                 delete _Ptr;
>                 ^
> C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\include\memory(2267,4):  note: in instantiation of member function 'std::default_delete<WebCore::CookieJarCurl>::operator()' requested here
>                         this->get_deleter()(get());
>                         ^
> DerivedSources\ForwardingHeaders\wtf/UniqueRef.h(42,7):  note: in instantiation of member function 'std::unique_ptr<WebCore::CookieJarCurl, std::default_delete<WebCore::CookieJarCurl> >::~unique_ptr' requested here
> class UniqueRef {
>       ^
> 3 warnings generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181113/23a897c2/attachment-0001.html>