[Webkit-unassigned] [Bug 181640] Support dynamic pseudo-classes on elements with display: contents

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 10:13:00 PST 2018


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |dino at apple.com
 Attachment #354330|review?                     |review+
              Flags|                            |

--- Comment #12 from Dean Jackson <dino at apple.com> ---
Comment on attachment 354330
  --> https://bugs.webkit.org/attachment.cgi?id=354330
rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354330&action=review

> Source/WebCore/dom/Element.cpp:2920
> +    if (!hasRareData())
> +        return nullptr;
> +    auto* style = elementRareData()->computedStyle();
> +    if (style && style->display() == DisplayType::Contents)

Could you have

if (!hasRareData() || !hasDisplayContents())
  return nullptr;

return elementRareData()->computedStyle();

Either way is fine with me.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181112/cac4b919/attachment.html>

More information about the webkit-unassigned mailing list