[Webkit-unassigned] [Bug 191380] [WTF] Changes in bug 188867 break non-Linux Unix builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 06:14:04 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=191380

--- Comment #12 from Jim Mason <jmason at ibinx.com> ---
I reviewed the code, and what I found was that all users of the GTK target were going through the Linux implementation.  That seems incorrect, since querying the memory map will vary by platform.  Moreover, releasing excess heap (if it is possible at all) will certainly be different, as malloc_trim is specific to Linux.

The previous patch fixed up compilation for non-Linux, but effectively resulted in a no-op situation for those platforms, since the working set could be neither queried nor modified.

I've updated PlatformGTK.cmake to include the Linux codepaths only for Linux; all other GTK users are shunted through the generic implementation, which currently is a no-op.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181109/efd13913/attachment.html>


More information about the webkit-unassigned mailing list