[Webkit-unassigned] [Bug 191455] New: WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191455

            Bug ID: 191455
           Summary: WebHistory.h: warning: 'QueryInterface' overrides a
                    member function but is not marked 'override'
                    [-Winconsistent-missing-override]
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com

WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Clang-cl reports following compilation warnings while building WinCairo port:

> [5754/6223] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebHistory.cpp.obj
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(54,39):  warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual HRESULT STDMETHODCALLTYPE QueryInterface(_In_ REFIID riid, _COM_Outptr_ void** ppvObject);
>                                       ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(113,47):  note: overridden virtual function is here
>             virtual HRESULT STDMETHODCALLTYPE QueryInterface( 
>                                               ^
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(55,37):  warning: 'AddRef' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual ULONG STDMETHODCALLTYPE AddRef();
>                                     ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(117,45):  note: overridden virtual function is here
>             virtual ULONG STDMETHODCALLTYPE AddRef( void) = 0;
>                                             ^
> In file included from ..\..\Source\WebKitLegacy\win\WebHistory.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebHistory.h(56,37):  warning: 'Release' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>     virtual ULONG STDMETHODCALLTYPE Release();
>                                     ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um\unknwnbase.h(119,45):  note: overridden virtual function is here
>             virtual ULONG STDMETHODCALLTYPE Release( void) = 0;
>                                             ^

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181109/f29bdc81/attachment.html>