[Webkit-unassigned] [Bug 191453] New: MediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191453

            Bug ID: 191453
           Summary: MediaPlayerPrivateMediaFoundation.h: warning:
                    'GetService' overrides a member function but is not
                    marked 'override' [-Winconsistent-missing-override]
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com

Clang-cl reports following compilation warnings while building WinCairo port:

> [5097/6223] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp.obj
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(361,43):  warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE GetService(REFGUID guidService, REFIID riid, LPVOID *ppvObject);
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfidl.h(4891,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE GetService( 
>                                           ^
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(364,43):  warning: 'ActivateObject' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE ActivateObject(REFIID riid, void **ppv);
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfobjects.h(5264,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE ActivateObject( 
>                                           ^
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(365,43):  warning: 'DetachObject' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE DetachObject();
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfobjects.h(5270,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE DetachObject( void) = 0;
>                                           ^
> In file included from ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:28:
> ..\..\Source\WebCore\platform\graphics\win/MediaPlayerPrivateMediaFoundation.h(366,43):  warning: 'ShutdownObject' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>         virtual HRESULT STDMETHODCALLTYPE ShutdownObject();
>                                           ^
> C:\Program Files (x86)\Windows Kits\10\include\10.0.17134.0\um/mfobjects.h(5268,43):  note: overridden virtual function is here
>         virtual HRESULT STDMETHODCALLTYPE ShutdownObject( void) = 0;
>                                           ^

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181109/91aa062e/attachment-0001.html>