[Webkit-unassigned] [Bug 189257] Resurrect WebKitTestRunner for Windows port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189257

--- Comment #13 from Takashi Komori <Takashi.Komori at sony.com> ---
>> Source/cmake/OptionsWin.cmake:87
>> +    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
>
>I want to know the reason why ENABLE_ACCESSIBILITY is needed.

It it for appending AccessiblityController.cpp into TestRunnerInjectedBundle project.
Because Windows ports add HAVE_ACCESSIBILITY definition automatically in Platform.h, if we don't append it we can't build AccessibilityControllerWin.cpp


>> Tools/WebKitTestRunner/PlatformWin.cmake:52
>> +    ${WEBKIT_TESTRUNNER_BINDINGS_DIR}/JSWrapper.cpp
>
>I want to know the reason why you remove JSWrapper.cpp.


WEBKIT_ADD_PRECOMPILED_HEADER overwrites ForcedIncludeFiles attribute (precompiled header), so we can't use this macro twice.
Because JSWrapper.cpp is reffered from two projects WebKitTestRunnerLib and WebKitTestRunnerInjectedBundle, building overwritten precompiled headers have a conflict.

JSWrapper.cpp doesn't require the header, so it is easy way to avoid this conflict.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181109/640b47dc/attachment.html>