[Webkit-unassigned] [Bug 191228] Plain text drag in contenteditable is always DragOperationCopy, never DragOperationMove

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 19:05:48 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=191228

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354196|review?                     |review+
              Flags|                            |

--- Comment #14 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 354196
  --> https://bugs.webkit.org/attachment.cgi?id=354196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354196&action=review

Nice! r=me, provided that EWS is happy.

> LayoutTests/fast/events/drag-and-drop-move-not-copy.html:18
> +   var range = document.createRange();

Do we need to create and set up this `range` here? It seems that setting base and extent below should be sufficient to make a selection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181108/363281ea/attachment.html>


More information about the webkit-unassigned mailing list