[Webkit-unassigned] [Bug 191228] Plain text drag in contenteditable is always DragOperationCopy, never DragOperationMove

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191228

--- Comment #8 from Jonathan Hammer <jonathan at e3software.com> ---
(In reply to Wenson Hsieh from comment #7)
> While this change looks reasonable, we'd also need to write a regression
> test for it. It should be possible to using existing infrastructure for
> testing drag and drop (LayoutTests/fast/events/drag-and-drop-*.html) to test
> this, but I haven't done the investigation to see whether it'll just work.
> Ideally we can just add a test that moves text within a textarea or
> contenteditable element and checks that the text isn't duplicated.

Thanks, Wenson. I'm not sure why my patch didn't include the ChangeLog diff (sorry, newbie here). Here's what I wrote in the changelog:

+        This change was tested manually, but I did not write a test case. Ideally, the 
+        DragAndDropSimulator could be used to test this code, but the simulator is WK2 only and
+        this change affects only WK1. I don't have the resources to build a drag simulator for 
+        WK1 at this time.

Per your suggestion, I'll take a look at LayoutTests/fast/events/drag-and-drop-*.html. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181107/17f70a5f/attachment.html>