[Webkit-unassigned] [Bug 189257] Resurrect WebKitTestRunner for Windows port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 05:00:35 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=189257

--- Comment #5 from Build Bot <ews at webkit.org> ---
Attachment 354083 did not pass style-queue:


ERROR: Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/WebKitTestRunner/win/TestControllerWin.cpp:189:  bundleDir_utf is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Tools/WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181107/1eb78986/attachment.html>


More information about the webkit-unassigned mailing list