[Webkit-unassigned] [Bug 191340] Web Inspector: Fix "Javascript" => "JavaScript" enum in protocol generated objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191340

--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 354033
  --> https://bugs.webkit.org/attachment.cgi?id=354033
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=354033&action=review

>> Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:70
>> +InspectorBackend.registerEnum("Canvas.ContextType", {Canvas2D: "canvas-2d", BitmapRenderer: "bitmaprenderer", WebGL: "webgl", WebGL2: "webgl2", Webgpu: "webgpu"});
> 
> The frontend uses CanvasAgent.ContextType.WebGPU. This change causes calls to InspectorCanvasAgent::requestContent to fail with "unsupported canvas context type".

Hmm, a couple things.

  • This seems to be a pre-existing mistake. Nothing in the frontend used `CanvasAgent.ContextType.Webgpu` only `CanvasAgent.ContextType.WebGPU` so this would be fixing iOS 11 support.
  • However, WI.Canvas.fromPayload has a mistake (missing `break`) that needs to be fixed!

Other than that, this is just changing the enum name, not the protocol string, so it's fine to make this change otherwise. I'll update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181107/066f88e4/attachment.html>