[Webkit-unassigned] [Bug 189257] Resurrect WebKitTestRunner for Windows port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189257

Build Bot <ews at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ews at webkit.org

--- Comment #2 from Build Bot <ews at webkit.org> ---
Attachment 353945 did not pass style-queue:


ERROR: Source/WebKit/PlatformWin.cmake:195:  Alphabetical sorting problem. "Shared/API/c/cairo" should be before "Shared/API/c/win".  [list/order] [5]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:30:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:120:  Missing space before {  [whitespace/braces] [5]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:183:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:183:  Missing spaces around <  [whitespace/operators] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:183:  Missing space before {  [whitespace/braces] [5]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:199:  Use the class HWndDC instead of calling GetDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:200:  Use adoptGDIObject and GDIObject<HDC> when calling CreateCompatibleDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:219:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:220:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:221:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:222:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:223:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:224:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:225:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:226:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/WebKitTestRunner/win/TestControllerWin.cpp:180:  Missing space before {  [whitespace/braces] [5]
ERROR: Tools/WebKitTestRunner/win/TestControllerWin.cpp:180:  Use nullptr instead of NULL.  [readability/null] [5]
ERROR: Tools/WebKitTestRunner/win/TestControllerWin.cpp:183:  Use nullptr instead of NULL.  [readability/null] [5]
ERROR: Tools/WebKitTestRunner/win/TestControllerWin.cpp:185:  bundle_dir is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Tools/WebKitTestRunner/win/TestControllerWin.cpp:189:  bundle_dir_utf is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Tools/WebKitTestRunner/win/TestControllerWin.cpp:190:  Use nullptr instead of NULL.  [readability/null] [5]
ERROR: Tools/WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 24 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181106/c34e794f/attachment-0001.html>