[Webkit-unassigned] [Bug 191160] Don’t use the main queue to create an XPC connection as xpc_connection_set_bootstrap does a dispatch_mach_send_barrier_f on this queue which delays the sending of subsequent bootstrap message

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 13:51:59 PST 2018


--- Comment #14 from Geoffrey Garen <ggaren at apple.com> ---
> There is an indentation change because I was dispatching the work using
> RunLoop::main().dispatch inside errorHandler function.

I see.

This is a great thing to explain in your ChangeLog: Now that the XPC connection runs on the default concurrent queue, our errorHandler may be invoked by any thread.

I think you should try to make this distinction clearer in code. I would declare an errorHandler and an errorHandlerImpl. The job of errorHandler is to dispatch to the main thread to invoke errorHanderlImpl. If you do things that way, the diff will be smaller, and it will be clearer that the only job of errorHandler is to forward events to our preferred thread.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181105/ee3b117c/attachment.html>

More information about the webkit-unassigned mailing list