[Webkit-unassigned] [Bug 191256] Fix build with disabled DFG/FTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191256

Guillaume Emont <guijemont at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guijemont at igalia.com

--- Comment #3 from Guillaume Emont <guijemont at igalia.com> ---
Comment on attachment 353846
  --> https://bugs.webkit.org/attachment.cgi?id=353846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353846&action=review

Did not try it yet, but the changes seem to make sense.
One suggestion for improvement though: the implementation of GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback() in bytecode/GetByIdStatus.cpp does not seem to be guarded by ENABLE(DFG_JIT) even though its definition in the .h is, so maybe we want to guard it too?

> Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:-55
> -#if ENABLE(DFG_JIT)
> -ExitFlag PutByIdStatus::hasExitSite(CodeBlock* profiledBlock, unsigned bytecodeIndex)
> -{
> -    return hasBadCacheExitSite(profiledBlock, bytecodeIndex);
> -}
> -#endif

Any idea why this function existed in the first place?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181105/ca6fdaf5/attachment-0001.html>