[Webkit-unassigned] [Bug 186105] Fix the ENABLE(DATALIST_ELEMENT) build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 31 09:24:15 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=186105

--- Comment #8 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Darin Adler from comment #7)
> Comment on attachment 341593 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341593&action=review
> 
> > Source/WebCore/rendering/RenderTheme.cpp:-1003
> > -    auto* dataList = downcast<HTMLDataListElement>(input.list());
> 
> I don’t understand the rationale for the changes in this file. None of them
> seem to be needed.

When attempting to build before the changes, I was met with a "No matching function for call to 'downcast'".

I now realize that I could have changed that specific line to use input.list().get() and kept the rest the same.

Is there a way that you prefer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180531/1f853157/attachment.html>


More information about the webkit-unassigned mailing list