[Webkit-unassigned] [Bug 185643] run-gtk-tests (glib/common.py) cannot determine build directory when webKitBranchBuild=true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185643

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 341187
  --> https://bugs.webkit.org/attachment.cgi?id=341187
Try to fix GTK+ build

View in context: https://bugs.webkit.org/attachment.cgi?id=341187&action=review

Looks good to me, with a nit :)

> Tools/glib/common.py:24
> +tools_dir = os.path.abspath(os.path.join(os.path.dirname(__file__), '..', '..', 'Tools', 'Scripts'))

I would rather use os.path.dirname() to navigate upwards in the
file system tree instead of using “..” path components, as in:

    tools_dir = abspath(join(dirname(dirname(dirname(__file__))), 'Tools', 'Scripts'))

The reason is that “..” is not guaranteed to be “one directory upwards in the
tree” in all systems (well, it is in Windows and Unix, which is what we support
after all, but using “dirname” is the correct thing).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180531/3ba1b170/attachment.html>