[Webkit-unassigned] [Bug 186146] [GTK] Switch to use a popup window with a tree view instead of a menu for option menu default implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186146

--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 341660
  --> https://bugs.webkit.org/attachment.cgi?id=341660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341660&action=review

This looks good to me, and having used these new popups
in Epiphany already for a while I *know* that they do work
much better, particularly in Wayland where the current 
implementation can have occasional popup window sizing
and placement issues.

I am for landing this, but probably it's good that someone else
who knows GTK+ well (for example, Michael Catanzaro) would take
a look as well.

> Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:270
> +    // https://gitlab.gnome.org/GNOME/gtk/issues/997

I wonder whether it would be possible avoid this kind of complex code by
(ab)using some GTK+ popup widget that behaves correctly on Wayland regarding
to positioning -- for example using a GtkPopover and then overriding its CSS
styling to make it look like a plain popup. Dunno, at any rate it's just a
thought, not a request to change anything in this patch.

(BTW, I commented in GTK+ bug #997 that having gdk_window_move_to_rect()
public would be useful for WebKitGTK+ as well, and from touching popup
layout code before I am quite confident we could use it in a few places.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180531/d38b0ddb/attachment.html>