[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126907

--- Comment #63 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Eduardo Ramalho from comment #62)
> (In reply to Carlos Garcia Campos from comment #57)
> 
> Thanks for the review! Forgot to respond to the suggestions and there was
> just one point I didn't follow:
> 
> > > Source/WebCore/rendering/RenderThemeGtk.cpp:982
> > > +    if (element)
> > > +        style.setColor(inputColor(element, Entry));
> > 
> > I think we should move this after the next if. Again, I think this could be
> > done with current styleColor().
> 
> Moving it after the if would result in only calling setColor in textInputs
> with spinButtons.

Oh, you are right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180531/17dbdf90/attachment.html>