[Webkit-unassigned] [Bug 185785] "symbolTablePutTouchWatchpointSet" is a terrible name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185785

--- Comment #1 from Yusuke Suzuki <utatane.tea at gmail.com> ---
What this function actually does is, [[Put]] operation onto the symbol table, at that time, touching a WatchpointSet (this is a class in JSC) for the entry in the symbol table. We have symbolTablePutInvalidateWatchpointSet too.

Why it is not defined as a member function of JSSymbolTableObject is because JSSymbolTableObject just holds the symbol table and it does not know the slot holding a value. These slots are offered separately. These derived class have `variableAt()` function, so the function's SymbolTableObjectType needs to be a template typename.

How about symbolTablePutWithTouchingWatchpointSet?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180530/c4f2db6a/attachment.html>