[Webkit-unassigned] [Bug 180866] AX: macOS VoiceOver doesn't announce when details element is expanded when using role group

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180866

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 341546
  --> https://bugs.webkit.org/attachment.cgi?id=341546
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341546&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2800
> +            return object.node() && is<HTMLDetailsElement>(object.node());

No need to do a null check if using is<>, which returns false for null. So it would be better to just write:

    return is<HTMLDetailsElement>(object.node());

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180530/5892d0f7/attachment.html>