[Webkit-unassigned] [Bug 186076] New: -[WKFullscreenStackView updateConstraints] doesn't handle secondaryMaterialOverlayView or secondaryMaterialOverlayViewConstraints consistently

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186076

            Bug ID: 186076
           Summary: -[WKFullscreenStackView updateConstraints] doesn't
                    handle secondaryMaterialOverlayView or
                    secondaryMaterialOverlayViewConstraints consistently
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media Elements
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: eric.carlson at apple.com, jeremyj-wk at apple.com,
                    jer.noble at apple.com, jonlee at apple.com

While investigating Bug 185887, I found some issues in Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm (in no particular order):

- The WKFullscreenStackView.secondaryMaterialOverlayViewConstraints instance variable is only ever set, and never read, and the constraints are recomputed every time -[WKFullscreenStackView updateConstraints] is called.  If it's never used outside of -updateConstraints, the instance variable can probably be removed.

- The WKFullscreenStackView.secondaryMaterialOverlayView instance variable is `assign`, but references a UIVisualEffectView object which can be deallocated.  This instance variable is set in -[WKFullscreenStackView updateConstraints], but only appears to be referenced again to remove it from its superview (the WKFullscreenStackView instance), after which the instance variable may point to a deallocated object.  (Since it's never used again, this doesn't seem to be a security issue.)  It seems like WKFullscreenStackView.secondaryMaterialOverlayView should probably be `retain`.

- Also, when WKFullscreenStackView.secondaryMaterialOverlayView is removed from its superview in -[WKFullscreenStackView updateConstraints], I'm not sure how it will ever be used again.

- Clean up inconsistent use of legacy/modern setter syntax and ivar/property access.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180530/8d2264b5/attachment.html>