[Webkit-unassigned] [Bug 185948] [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185948

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Xabier Rodríguez Calvar from comment #10)
> Comment on attachment 341282 [details]
> Patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341282&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:319
> > +    if (streamEncryptionAllowedSystems) {
> > +        for (i = 0; streamEncryptionAllowedSystems[i]; ++i)
> > +            streamEncryptionAllowedSystemsVector.append(streamEncryptionAllowedSystems[i]);
> > +    }
> 
> We don't need the brackets here, I think.

https://webkit.org/code-style-guidelines/#braces-one-line

> > Tools/gstreamer/jhbuild.modules:74
> > +      <patch file="gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch" strip="1" />
> 
> You can add a comment <!-- Merged in master, scheduled for 1.16.0 -->
> because we don't have the commit id yet but we will and we want to ensure
> that it is clear where it is now and will be release. Actually, the
> information about the patches scheduled for 1.16 should be in the others too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180525/755ad42f/attachment.html>