[Webkit-unassigned] [Bug 183586] Custom Elements: connectedCallback is invoked at unexpected timing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 06:37:00 PDT 2018


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #341272|review?                     |review+
              Flags|                            |

--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 341272
  --> https://bugs.webkit.org/attachment.cgi?id=341272

View in context: https://bugs.webkit.org/attachment.cgi?id=341272&action=review

Looks sane to me.


> Source/WebCore/html/parser/HTMLDocumentParser.cpp:210
> +            m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement), *constructionData);

This patch is ok as-is. We always execute this line. I suggest we move this line to be above the return (line 212) instead of duplicating it in both branches.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180525/d155504a/attachment.html>

More information about the webkit-unassigned mailing list