[Webkit-unassigned] [Bug 185783] test262/Runner.pm: add unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185783

--- Comment #34 from Daniel Bates <dbates at webkit.org> ---
(In reply to Daniel Bates from comment #33)
> 
> Buildbot unit tests are the appropriate solution to catch such regressions.
> The Buildbot code and unit tests are in
> Tools/BuildSlaveSupport/build.webkit.org-config. In particular, the unit
> tests for the Buildbot steps are in
> <https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.
> webkit.org-config/steps_unittest.py?rev=231570>. You may find it beneficial
> to look at the unit tests classes RunJavaScriptCoreTestsTest and
> RunWebKitTestsTest for inspiration on how to write tests for the output of
> the runner.
> 

Disregard this remark. Buildbot unit tests will not catch such regressions. It is still beneficial to add Buildbot unit tests to catch parsing regressions in how we "surface those errors" in the Buildbot UI.

> > > If we chose
> > > to move forward with adding tests for the driver then can we at least mock
> > > out the calls to the jsc binary and their results so that we can avoid the
> > > need to use the real jsc binary and hence get into the situation with have
> > > now of what jsc binary to use (debug/release/system)? Can we make more use
> > > of webkitdirs.pm?
> > 
> > Interesting idea. I hope my colleague Leo Balter can look into this. He'll
> > take over future patches on this bug. As of this moment, I'm out on vacation
> > for two weeks!
> 
> See my remark above about Buildbot unit tests. Buildbot unit test seem more
> appropriate for your purpose.

Disregard this remark.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180525/82138a0d/attachment.html>