[Webkit-unassigned] [Bug 180398] WebDriver: implement maximize, minimize and fullscreen window commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180398

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 340956
  --> https://bugs.webkit.org/attachment.cgi?id=340956
Try to fix iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=340956&action=review

>> Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp:117
>> +    }
> 
> These all look wrong to me, shouldn't it be something like:
> 
> if (auto* webView = webkitWebContextGetWebViewForPage(m_session->priv->webContext, &page))
>     webkitWebViewMaximizeWindow(webView, WTFMove(completionHandler));
> else
>     completionHandler();
> 
> Otherwise you're calling WebKitWebView methods with a NULL webview, and the completion handler could be called twice.
> 
> r=me on the rest of the GTK bits.

Oops, you are right, there's a missing return in all those cases after completionHandler(); I'll better use your proposal

>> Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:134
>> +    RunLoop::Timer<WindowStateEvent> completeTimer;
> 
> How about some m_ for these?

This is a struct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180523/274ec344/attachment.html>