[Webkit-unassigned] [Bug 185893] New: Logging macros are sensitive to pal/Logging.h vs Logging.h include order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185893

            Bug ID: 185893
           Summary: Logging macros are sensitive to pal/Logging.h vs
                    Logging.h include order
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com

Add a #include <pal/Logging.h> to a .cpp file can break the build, because subsequent files in the same UnifiedSources*.cpp may use the LOG macro, and pal/Logging.h and Logging.h #define LOG_CHANNEL_PREFIX to different things.

I don't think pal/Logging.h should define any log channels, nor define LOG_CHANNEL_PREFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/88df356a/attachment-0001.html>