[Webkit-unassigned] [Bug 185783] test262/Runner.pm: add unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185783

--- Comment #12 from Jonathan Bedard <jbedard at apple.com> ---
(In reply to valerie from comment #11)
> (In reply to Jonathan Bedard from comment #10)
> 
> > > Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:48
> > > +my $ToolsPath = $ENV{'WEBKIT_LIBRARIES'};
> > 
> > Nit: Not a class, should start with a lower-case T
> > 
> > Also, I'm pretty sure this isn't the right way to do this.  Just tried
> > applying your patch and running locally on my machine (via test-webkitperl)
> > I see errors like this:
> > Can't exec "/Tools/Scripts/test262-runner": No such file or directory at
> > Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 132.
> > 
> 
> I copied this from other tests in webkitperl. I also set WEBKIT_LIBRARIES in
> my bash scripts -- I thought it might be standard? Perhaps not if you
> haven't heard of it. 
> 
> Can you think of a better way to do it, or should I just keep this (as it's
> at least consistent with a couple other webkit perl scripts?
> 
> I originally wanted to use webkitperl.pm, but that module doesn't expose
> `determineSourceDir` -- the function to get the root of the webkit directory
> repo.

When we do these sorts of things in Python and bash, we will try and make the module self contained by referencing outside resources relative to the module file.  That seems like the correct approach here.  For Perl, that would be dirname(__FILE__).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/7259457c/attachment.html>