[Webkit-unassigned] [Bug 183586] Custom Elements: connectedCallback is invoked at unexpected timing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 14:06:36 PDT 2018


--- Comment #9 from youenn fablet <youennf at gmail.com> ---
(In reply to Chris Dumez from comment #7)
> Comment on attachment 341004 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341004&action=review
> >> LayoutTests/imported/w3c/ChangeLog:8
> >> +        * web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.html: Added.
> > 
> > Don't add a test to LayoutTests/imported/w3c. Add it to fast/custom-elements instead.
> > r- because adding a test test to LayoutTests/imported/ is forbidden.
> +Youenn because I thought that's how we upstreamed WPT tests now.

We have done the following workflow:
- Do a patch which add or update WPT tests
- Make a corresponding PR on WPT GitHub and add a link to it in bugzilla
- Make the usual review process in WebKit (and/or WPT)
- Merge the WPT GitHub PR
- Land the WebKit patch

The alternative is to make the GitHub PR first and then reimport the WPT tests as part of the WebKit patch or as a prepunch.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/72353dc5/attachment.html>

More information about the webkit-unassigned mailing list