[Webkit-unassigned] [Bug 185783] test262/Runner.pm: add unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185783

--- Comment #7 from Jonathan Bedard <jbedard at apple.com> ---
(In reply to valerie from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> 
> > > Tools/Scripts/test262/Runner.pm:265
> > > +    if ($Mode ne 'TESTING') { # if testing, no need to load harness files
> > 
> > Is there any harm in loading harness files while testing?.  We aren't really
> > resource constrained in webkitperl tests.
> 
> These tests supply "--test262" command line option which points to a "fake"
> test262 in the directory "webkitperl/test262-unittest/fixture". The harness
> directory is expect to be found in the directory supplied by "--test262",
> but I didn't want to copy over the harness files here (it would be another
> thing that could easily get out of date).
> 
> Do you think it would be better to copy over the expected harness files, or
> to silently ignore them if they don't exist, rather than have this
> environment option?

So if I'm understanding this correctly, the directory directory that --test262 is replacing contains both the harness and testing files in production?

It seems to me, then, that either the harness files shouldn't live with the testing files or that we should fallback to the production harness files if there are not harness files in the testing directory.  This would allow you to eliminate the whole 'testing' directory idea.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/e4b4a62f/attachment-0001.html>