[Webkit-unassigned] [Bug 185819] Crash when loading a SVG image

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 00:44:47 PDT 2018


--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Alex Christensen from comment #7)
> Comment on attachment 340848 [details]
> Patch
> Why is this not testable?

I tried to make a test case, but I couldn't. I'm not familiar with SVG, it seems to happen when an image tag inside an svg contains another image, but I haven't managed te create a test. This always happens when visiting http://www.mutua.es. I also tried to extract the test case from that page but failed too. If someone knows how to create a test case for this we can add it in a follow up patch.

> Why don't we make
> WebResourceLoader::TrackingParameters::pageID and frameID std::optional, too?

I don't think that helps. The tracking parameters are used in a lot of log messages, we would need to use value_or(0) everywhere. Then we would also need to make std::optional webPageID and webFrameID in NetworkLoadParameters (or use vale_or(0) when assigning the network load parameters). That would also require a lot of changes in network process code. If we ever get rid of the empty client, those will no longer be optional, so I don't think it's worth all the changes involved.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/3bd3e702/attachment-0001.html>

More information about the webkit-unassigned mailing list