[Webkit-unassigned] [Bug 185278] Remove dead exception in MediaList.appendMedium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 18:45:41 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185278

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cdumez at apple.com
 Attachment #339557|review?                     |review+
              Flags|                            |

--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 339557
  --> https://bugs.webkit.org/attachment.cgi?id=339557
Add back GError parameter

View in context: https://bugs.webkit.org/attachment.cgi?id=339557&action=review

r=me with nit.

> Source/WebCore/css/MediaList.cpp:211
> +    bool added = m_mediaQueries->add(medium);

I do not think we need this local. Could be:
if (!m_mediaQueries->add(medium))
    return;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/ee941981/attachment.html>


More information about the webkit-unassigned mailing list