[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126907

--- Comment #36 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Carlos Eduardo Ramalho from comment #33)
> Simply adding "color: $fg_color" solved it for me. Can the GTK developers
> confirm this is the case?

I guess the problem here is that it proves that color is not actually what GTK+ is looking at when it draws the text entry here. Otherwise, text entries would be broken in all other GTK+ apps, right? So we can certainly add a line of CSS to the theme, that's no problem, but I suspect it's not the right fix as we'd ideally want to draw the same thing as GTK+.

Eventually we're going to have to rewrite everything to not use gtk_css_context_get_color() at all (it's at risk of removal from GTK+), nor gtk_css_context_get_background_color() (a more immediate problem as that one is gone in GTK+ 4), but that's definitely beyond the scope of this bug.

(In reply to Carlos Eduardo Ramalho from comment #35)
> I'm not sure window.background is really the way to go because of my
> findings in the above comment which I did before seeing this. However the
> "webview" gadget is a good idea for themers indeed. Maybe place this in
> another bug?

We should do both, perhaps in another bug if it turns out to not be necessary to solve this one, yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180522/d76b20fe/attachment.html>