[Webkit-unassigned] [Bug 183583] connectedCallback called when disconnected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183583

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340871|review?                     |review-
              Flags|                            |

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 340871
  --> https://bugs.webkit.org/attachment.cgi?id=340871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340871&action=review

I don't think this change is correct. For that matter, I believe WebKit's current behavior is in accordance with the specification.

> Source/WebCore/dom/CustomElementReactionQueue.cpp:80
> -            elementInterface.invokeConnectedCallback(element);
> +            if (element.isConnected())
> +                elementInterface.invokeConnectedCallback(element);

There is no spec text which mandates a check like this:
https://html.spec.whatwg.org/multipage/custom-elements.html#invoke-custom-element-reactions

> LayoutTests/fast/custom-elements/connected-callback.html:12
> +        while (this.firstChild) {

Why while?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180521/da263fb7/attachment-0001.html>