[Webkit-unassigned] [Bug 185783] test262/Runner.pm: add unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185783

Jonathan Bedard <jbedard at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbedard at apple.com

--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 340736
  --> https://bugs.webkit.org/attachment.cgi?id=340736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340736&action=review

> Tools/ChangeLog:11
> +        (main):

It seems worth explaining why changes are required here.

> Tools/Scripts/test262/Runner.pm:265
> +    if ($Mode ne 'TESTING') { # if testing, no need to load harness files

Is there any harm in loading harness files while testing?.  We aren't really resource constrained in webkitperl tests.

> Tools/Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js:8
> +throw "Test262Unexpected: This test errors WITH A UNEXPECTED ERROR.";

Nit: Change to 'Test262Unexpected: This test fails WITH AN UNEXPECTED ERROR.'

> Tools/Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js:8
> +throw "Test262: This test errors.";

Nit: Change to 'Test262: This test fails.'

> Tools/Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js:8
> +throw "Test262: This test errors.";

Nit: Change to 'Test262: This test fails.'

> Tools/Scripts/webkitperl/test262_unittest/fixtures/test/fail.js:8
> +throw "Test262: This test errors.";

Nit: Change to 'Test262: This test fails.'

> Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:42
> +if ($^O eq 'MSWin32' && $^O eq 'cygwin') {

Shouldn't this be or?  I believe that we have a non-cygwin windows port.  (WinCairo)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180521/e618fb5f/attachment.html>