[Webkit-unassigned] [Bug 185801] New: dump-class-layout seems wrong

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185801

            Bug ID: 185801
           Summary: dump-class-layout seems wrong
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com
                CC: lforschler at apple.com

After r229291 the results of dump-class-layout seem suspect.

Before:
 18$ $ ./Tools/Scripts/dump-class-layout -c Release JavaScriptCore SourceProvider
Found 1 types matching "SourceProvider" in "/Volumes/Data/Development/apple/webkit/OpenSource/WebKitBuild/Release/JavaScriptCore.framework/JavaScriptCore" for x86_64
  +0 { 80} SourceProvider
  +0 <  8>     __vtbl_ptr_type * _vptr;
  +8 {  4}     WTF::RefCounted<JSC::SourceProvider>
  +8 {  4}         WTF::RefCountedBase
  +8 <  4>             unsigned int m_refCount;
 +12 <  4>     <PADDING>
 +16 < 16>     JSC::SourceOrigin m_sourceOrigin;
 +16 <  8>         WTF::String m_string;
 +16 <  8>             WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > m_impl;
 +16 <  8>                 WTF::DumbPtrTraits<WTF::StringImpl>::StorageType m_ptr;
 +24 <  8>         WTF::RefPtr<JSC::ScriptFetcher, WTF::DumbPtrTraits<JSC::ScriptFetcher> > m_fetcher;
 +24 <  8>             WTF::DumbPtrTraits<JSC::ScriptFetcher>::StorageType m_ptr;
 +32 <  8>     WTF::String m_url;
 +32 <  8>         WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > m_impl;
 +32 <  8>             WTF::DumbPtrTraits<WTF::StringImpl>::StorageType m_ptr;
 +40 <  8>     WTF::String m_sourceURLDirective;
 +40 <  8>         WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > m_impl;
 +40 <  8>             WTF::DumbPtrTraits<WTF::StringImpl>::StorageType m_ptr;
 +48 <  8>     WTF::String m_sourceMappingURLDirective;
 +48 <  8>         WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > m_impl;
 +48 <  8>             WTF::DumbPtrTraits<WTF::StringImpl>::StorageType m_ptr;
 +56 <  8>     WTF::TextPosition m_startPosition;
 +56 <  4>         WTF::OrdinalNumber m_line;
 +56 <  4>             int m_zeroBasedValue;
 +60 <  4>         WTF::OrdinalNumber m_column;
 +60 <  4>             int m_zeroBasedValue;
 +64 <  4>     JSC::SourceProviderSourceType m_sourceType;
 +68 <  1>     bool:1 m_validated;
 +69 <  3>     <PADDING>
 +72 <  8>     uintptr_t:63 m_id;
Total byte size: 80
Total pad bytes: 7
Padding percentage: 8.75 %

After:

 16$ $ ./Tools/Scripts/dump-class-layout -c Release JavaScriptCore SourceProvider
Found 1 types matching "SourceProvider" in "/Volumes/Data/Development/apple/webkit/OpenSource/WebKitBuild/Release/JavaScriptCore.framework/JavaScriptCore" for x86_64
  +0 { 80} SourceProvider
  +0 <  8>     __vtbl_ptr_type * _vptr;
  +8 {  4}     WTF::RefCounted<JSC::SourceProvider>
  +8 {  4}         WTF::RefCountedBase
  +8 <  4>             unsigned int m_refCount;
 +12 <  4>     <PADDING>
 +16 < 16>     JSC::SourceOrigin m_sourceOrigin;
 +16 <  8>         WTF::String m_string;
 +16 <  8>             WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > m_impl;
 +16 <  8>                 WTF::DumbPtrTraits<WTF::StringImpl>::StorageType m_ptr;
 +24 <  8>         WTF::RefPtr<JSC::ScriptFetcher, WTF::DumbPtrTraits<JSC::ScriptFetcher> > m_fetcher;
 +24 <  8>     <PADDING>
 +32 <  8>     WTF::String m_url;
 +32 <  8>     <PADDING>
 +40 <  8>     WTF::String m_sourceURLDirective;
 +40 <  8>     <PADDING>
 +48 <  8>     WTF::String m_sourceMappingURLDirective;
 +48 <  8>     <PADDING>
 +56 <  8>     WTF::TextPosition m_startPosition;
 +56 <  4>         WTF::OrdinalNumber m_line;
 +56 <  4>             int m_zeroBasedValue;
 +60 <  4>         WTF::OrdinalNumber m_column;
 +60 <  4>     <PADDING>
 +64 <  4>     JSC::SourceProviderSourceType m_sourceType;
 +68 <  1>     bool:1 m_validated;
 +69 <  3>     <PADDING>
 +72 <  8>     uintptr_t:63 m_id;
Total byte size: 80
Total pad bytes: 43
Padding percentage: 53.75 %

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180519/b857eb12/attachment-0001.html>