[Webkit-unassigned] [Bug 185777] Click events only fire once when editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 18 13:36:43 PDT 2018


--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 340726
  --> https://bugs.webkit.org/attachment.cgi?id=340726

View in context: https://bugs.webkit.org/attachment.cgi?id=340726&action=review

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:714
>> +    if (node->document().focusedElement() == node)
> We probably only want to bail here if we're also editing...
> Otherwise, this means that if an element that's not in editable content already has focus, we will no longer flash the tap highlight over that node.
> For instance, if you have a <button id='button'> and call button.focus(), we should still see the tap highlight over the button if you tap on it. Perhaps we could check if m_assistedNode == node instead?

Actually, checking against m_assistedNode is probably still won't work in the case of editable elements that have been programmatically focused (select, input, textarea, etc.) prior to the tap...

We really only want to suppress the tap highlight if we've tapped inside a node that is assisted in the UI process (i.e. the keyboard is up and the selection assistant is active).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180518/3e7c3751/attachment.html>

More information about the webkit-unassigned mailing list