[Webkit-unassigned] [Bug 185045] Enhanced Download Build Product Script with Additional Use Cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185045

--- Comment #19 from youenn fablet <youennf at gmail.com> ---
> >> Tools/Scripts/webkitpy/common/build_binaries_fetcher.py:43
> >> +    def __init__(self, host, platform, architecture='x86_64', configuration='release', full=False, revision=None, build_directory=None, delete_first=False, no_extract=False, url=None):
> > 
> > Do we need architecture and configuration defaults?
> > It seems current call sites provide those values explicitly.
> 
> Good question - I left this in because I didn't want to rely on an external
> dependency to set the defaults.
> This brings up a larger question on where validation should live. 
> I considered moving the `supported_platforms` logic into its own common
> helper file, and methods for architecture and configuration can also live
> there and be imported here. 
> Should this class have its own validation helpers which check that the 
> platform, architecture, and configuration are in the shared globals?

Sounds ok to me, as long as the validation code is shared by all users.

> >> Tools/Scripts/webkitpy/common/build_binaries_fetcher.py:53
> >> +        self.s3_zip_url = url
> > 
> > I am not sure all these values need to be public.
> 
> public api - platform, architecture,  revision, build_directory, s3_zip_url?

Usually, we go to private by default and public if needed.
So maybe these values could be made private if they are not used elsewhere for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180518/8cda41b8/attachment.html>