[Webkit-unassigned] [Bug 185746] [Curl] Enable HTTP/2 Multiplexing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185746

--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to youenn fablet from comment #2)
> Comment on attachment 340654 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340654&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [Curl] Enable HTTP/2 Multiplexing
> 
> Nice!

Getting closer to having it working all the way but this flag is needed for us to keep digging deeper into it. This particular flag on curl_multi got lost in us dividing up patches to land.

> 
> > Source/WebCore/ChangeLog:8
> > +        Covered by existing tests.
> 
> I do not think WebKit has HTTP/2 test infra so I guess you have your own
> internal tests?

Oh my mistake. I figured there was something in there to test that HTTP/2 is working properly.

> 
> > Source/WebCore/platform/network/curl/CurlContext.cpp:202
> > +        curl_multi_setopt(m_multiHandle, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX);
> 
> Will the handle support both HTTP/2 and HTTP/1.1?

Yea internally curl makes that decision.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180517/90ac974e/attachment.html>