[Webkit-unassigned] [Bug 185742] AX: [macOS] Expose the primary screen height through AX API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185742

--- Comment #5 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 340632
  --> https://bugs.webkit.org/attachment.cgi?id=340632
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340632&action=review

Will also looking at the test failures

>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1831
>> +    FloatRect screenRect = screenRectForPrimaryScreen();
> 
> will this still work if the window is on a 2nd monitor?

Yes. It will always return the primary screen height

>> Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:50
>> +#ifndef NSAccessibilityPrimaryScreenHeightAttribute
> 
> there must be one place in WebCore that we can put this string.

Ok looking

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180517/e7a7cb8e/attachment.html>