[Webkit-unassigned] [Bug 184914] Export changes to web-platform-test as part of the webkit-patch upload workflow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 14:39:00 PDT 2018


--- Comment #26 from youenn fablet <youennf at gmail.com> ---
(In reply to youenn fablet from comment #25)
> Brendan, I updated my build and did changes to -expected.txt files in
> LayoutTests/imported/w3c/web-platform-tests.
> It was then suggesting me to export the changes to WPT GitHub, while it
> should not.
> Can you look at this?

The issue is that we are currently filtering out expected.txt files at the time we do apply_mail_patch.
Maybe we could do it at time of creation of the patch instead.
Or we could update our heuristic to check for lines starting with diff and without '-expected.txt' in it.

If it is difficult to fix it quickly, we can roll the patch out.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180517/1c69510d/attachment.html>

More information about the webkit-unassigned mailing list