[Webkit-unassigned] [Bug 185242] [MSE][GStreamer] Delete properly the stream from the WebKitMediaSource

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 05:04:56 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185242

--- Comment #15 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Alicia Boya GarcĂ­a from comment #13)
> > 1. I'll push a new patch to remove a part of this patch (185242) which caused the blocking.
> 
> Is there a reason to keep some parts of this patch? Which ones?

I keep the part which update the "source->priv->numberOfXXXXStreams"

 527    GST_OBJECT_LOCK(source);
 528    switch (stream->type) {
 529    case WebCore::Audio:
 530        source->priv->numberOfAudioStreams--;
 531        break;
 532    case WebCore::Video:
 533        source->priv->numberOfVideoStreams--;
 534        break;
 535    case WebCore::Text:
 536        source->priv->numberOfTextStreams--;
 537        break;
 538    default:
 539        break;
 540    }
 541    GST_OBJECT_UNLOCK(source);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180517/def06d6b/attachment.html>


More information about the webkit-unassigned mailing list