[Webkit-unassigned] [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185611

--- Comment #15 from Thibault Saunier <tsaunier at gnome.org> ---
Comment on attachment 340429
  --> https://bugs.webkit.org/attachment.cgi?id=340429
[GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions

View in context: https://bugs.webkit.org/attachment.cgi?id=340429&action=review

>> Source/WebKit/UIProcess/ChildProcessProxy.cpp:80
>> +        return;
> 
> Always assume the assertion never fails! So remove the return, since it's supposed to be unreachable. Just let it crash on the next line if the assertion fails.

I don't call that being resilient :-). but well... as you whish.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180516/634065d2/attachment.html>