[Webkit-unassigned] [Bug 126907] [GTK] Hardcoded text color in input fields
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 19:54:36 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=126907
--- Comment #21 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
Created attachment 340464
--> https://bugs.webkit.org/attachment.cgi?id=340464&action=review
Easiest solution. WIP
Well, the easiest solution I found here was simply enforcing Adwaita light theme in RenderThemeGadget.
To test in MiniBrowser:
$ export GTK_THEME=Adwaita:dark
$ run-minibrowser --gtk https://bugs.webkit.org/query.cgi?format=advanced
You'll see that the browser UI is dark but the inputs inside the page aren't
However, it's far from ideal as others GTK+ light themes could not be used and you guys probably won't like it. Maybe it's not in the best place either.
In my opinion WebKitGTK+ should just stick to Adwaita light for styling webpage widgets as it's really up to the web developer to style its elements and we should just not interfere with pages that don't.
For example, currently a <input type="text" /> with no style has its text unreadable if using a GTK dark theme. Also, text inputs, checkboxes and radio buttons seem very strange in pages with light theming e.g bugs.webkit.org
However it's the owners decision. So what do you think?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180516/99ebdd34/attachment.html>
More information about the webkit-unassigned
mailing list