[Webkit-unassigned] [Bug 185045] Enhanced Download Build Product Script with Additional Use Cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185045

--- Comment #11 from Amal Hussein <amal at bocoup.com> ---
(In reply to Alexey Proskuryakov from comment #9)
> Comment on attachment 340416 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340416&action=review
> 
> > Tools/BuildSlaveSupport/download-built-product:3
> > -# Copyright (C) 2009 Apple Inc.  All rights reserved.
> > +# Copyright (C) 2018 Apple Inc.  All rights reserved.
> 
> The copyright line is supposed to include all years in which published
> contributions were made, not just the latest. I'm not exactly sure why this
> says 2009 when the file was created in 2012, but perhaps that's because code
> was copy/pasted from an older file.

Good catch Alexey! Updated. 

Unrelated question: I'm not sure how to update the svn ignore. Do I need to check out the svn version of webkit? 

I've tried running `svn propset svn:ignore /DownloadedBinaries/ .` but it throws an svn: E155007: error with this msg my `/webkit' is not a working copy`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180515/272acf48/attachment-0001.html>