[Webkit-unassigned] [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185611

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340429|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340429
  --> https://bugs.webkit.org/attachment.cgi?id=340429
[GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions

View in context: https://bugs.webkit.org/attachment.cgi?id=340429&action=review

> Source/WebKit/ChangeLog:12
> +        https://bugs.webkit.org/show_bug.cgi?id=185611

It's redundant as you already have it up above.

> Source/WebKit/UIProcess/ChildProcessProxy.cpp:80
> +        return;

Always assume the assertion never fails! So remove the return, since it's supposed to be unreachable. Just let it crash on the next line if the assertion fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180515/7017b44a/attachment.html>