[Webkit-unassigned] [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 13:23:42 PDT 2018


--- Comment #12 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Michael Catanzaro from comment #10)
> I *think* it should be safe to just swap the order of those function calls,
> because it *looks* like nothing inside
> PluginProcessProxy::platformGetLaunchOptions will break for either Mac or
> GTK.

Done that and it seem to fix the issue indeed.

> To ensure this is more robust, we really need a default ASSERT_NOT_REACHED()
> case inside ChildProcessProxy::getLaunchOptions.

Also added the assertion.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180515/8e7be75a/attachment.html>

More information about the webkit-unassigned mailing list