[Webkit-unassigned] [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185611

--- Comment #10 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Thibault Saunier from comment #9)
> I have no idea what should be set as a `launchOptions.processType` there,
> any idea?

It's supposed to be set by the child class override of ChildProcessProxy::getLaunchOptions.

Look here:

void PluginProcessProxy::getLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions)
{
    ChildProcessProxy::getLaunchOptions(launchOptions);
    platformGetLaunchOptions(launchOptions, m_pluginProcessAttributes);
}

That looks like the bug: the process type is set inside PluginProcessProxy::platformGetLaunchOptions, but that's too late because ChildProcessProxy expects it to have been set already.

I *think* it should be safe to just swap the order of those function calls, because it *looks* like nothing inside PluginProcessProxy::platformGetLaunchOptions will break for either Mac or GTK.

To ensure this is more robust, we really need a default ASSERT_NOT_REACHED() case inside ChildProcessProxy::getLaunchOptions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180515/d313b5f0/attachment.html>